Remove one unnecessary call for sign_holder_commitment_and_htlcs #2579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpaulino
reviewed
Sep 15, 2023
|
LGTM. Can you squash and follow our preferred commit message format? |
rmalonson
force-pushed
the
unsignedtx
branch
from
ff65ea8 to
e330414
Compare
wpaulino
previously approved these changes
Sep 15, 2023
|
Please limit the commit title (and all lines) to 60/70 chars at max. The title should always be followed by a blank line. |
|
@TheBlueMatt I think you missed the latest push? Commit looks fine. |
|
Ah, I did. The joys of airplane wifi. |
TheBlueMatt
previously approved these changes
Sep 15, 2023
G8XSU
reviewed
Sep 15, 2023
rmalonson
dismissed stale reviews from TheBlueMatt and wpaulino
via
9850c58
rmalonson
force-pushed
the
unsignedtx
branch
from
e330414 to
9850c58
Compare
wpaulino
approved these changes
Sep 15, 2023
TheBlueMatt
approved these changes
Sep 15, 2023
G8XSU
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small first step towards supporting async calls for sign_holder_commitment_and_htlcs (#2520). Here we remove an unnecessary call to onchain_tx_handler.get_fully_signed_holder_tx since it is only being used to pass the current commitment transaction to get_broadcasted_holder_watch_outputs, which doesn't require the transaction to be signed.